-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add video keyframe extraction #791
Conversation
Codecov ReportBase: 83.92% // Head: 83.95% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #791 +/- ##
===========================================
+ Coverage 83.92% 83.95% +0.02%
===========================================
Files 173 173
Lines 22739 22779 +40
Branches 4946 4951 +5
===========================================
+ Hits 19083 19123 +40
Misses 2535 2535
Partials 1121 1121
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Just one minor comment, I think It seems good to add comment for adding epsilon.
cf37acb
to
c6c2657
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Summary
Depends on #100408.
How to test
datum create -o proj
datum import -f video_keyframes -p proj video.mp4 -t 0.3 --
datum export -p proj -f image_dir --
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.