Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video keyframe extraction #791

Merged
merged 9 commits into from
Jan 18, 2023

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Jan 13, 2023

Summary

Depends on #100408.

  • Added ZNCC-based keyframe extractor feature

How to test

datum create -o proj
datum import -f video_keyframes -p proj video.mp4 -t 0.3 --
datum export -p proj -f image_dir --

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2023

Codecov Report

Base: 83.92% // Head: 83.95% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (74bd629) compared to base (6f481cc).
Patch coverage: 95.12% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #791      +/-   ##
===========================================
+ Coverage    83.92%   83.95%   +0.02%     
===========================================
  Files          173      173              
  Lines        22739    22779      +40     
  Branches      4946     4951       +5     
===========================================
+ Hits         19083    19123      +40     
  Misses        2535     2535              
  Partials      1121     1121              
Flag Coverage Δ
macos-11_Python-3.10 83.87% <95.12%> (+0.02%) ⬆️
macos-11_Python-3.7 83.55% <94.87%> (+0.02%) ⬆️
macos-11_Python-3.8 83.79% <95.12%> (+0.02%) ⬆️
macos-11_Python-3.9 83.81% <95.12%> (+0.03%) ⬆️
ubuntu-20.04_Python-3.10 83.87% <95.12%> (+0.02%) ⬆️
ubuntu-20.04_Python-3.7 83.55% <94.87%> (+0.02%) ⬆️
ubuntu-20.04_Python-3.8 83.80% <95.12%> (+0.02%) ⬆️
ubuntu-20.04_Python-3.9 83.81% <95.12%> (+0.02%) ⬆️
windows-2019_Python-3.10 83.83% <95.12%> (+0.02%) ⬆️
windows-2019_Python-3.7 83.51% <94.87%> (+0.02%) ⬆️
windows-2019_Python-3.8 83.75% <95.12%> (+0.02%) ⬆️
windows-2019_Python-3.9 83.77% <95.12%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/video.py 92.85% <95.12%> (+1.94%) ⬆️
datumaro/cli/contexts/project/__init__.py 72.68% <0.00%> (+0.97%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

datumaro/plugins/data_formats/video.py Outdated Show resolved Hide resolved
datumaro/plugins/data_formats/video.py Outdated Show resolved Hide resolved
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Jan 16, 2023
bonhunko
bonhunko previously approved these changes Jan 17, 2023
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

sooahleex
sooahleex previously approved these changes Jan 17, 2023
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one minor comment, I think It seems good to add comment for adding epsilon.

@wonjuleee wonjuleee dismissed stale reviews from sooahleex and bonhunko via 140b012 January 17, 2023 03:55
tests/cli/test_video.py Outdated Show resolved Hide resolved
datumaro/plugins/data_formats/video.py Outdated Show resolved Hide resolved
datumaro/plugins/data_formats/video.py Outdated Show resolved Hide resolved
datumaro/plugins/data_formats/video.py Outdated Show resolved Hide resolved
datumaro/plugins/data_formats/video.py Outdated Show resolved Hide resolved
datumaro/plugins/data_formats/video.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit cde50cf into openvinotoolkit:develop Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants