Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tile transformation #790

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jan 10, 2023

Signed-off-by: Kim, Vinnam vinnam.kim@intel.com

Summary

Example

Original DatasetItem Tiled DatasetItems (2x2) Tiled DatasetItems (3x3)
image image image

How to test

Run our unit tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim marked this pull request as draft January 10, 2023 03:19
@vinnamkim vinnamkim force-pushed the feature/tiling branch 3 times, most recently from 99e295a to bc75823 Compare January 10, 2023 15:02
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor reviews.

datumaro/plugins/tiling/util.py Outdated Show resolved Hide resolved
tests/test_tiling.py Outdated Show resolved Hide resolved
datumaro/components/annotation.py Show resolved Hide resolved
datumaro/plugins/tiling/tile.py Show resolved Hide resolved
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
bonhunko
bonhunko previously approved these changes Jan 11, 2023
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 - To follow Datumaro architecture

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2023

Codecov Report

Base: 83.84% // Head: 83.92% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (71345ea) compared to base (99d0396).
Patch coverage: 93.25% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #790      +/-   ##
===========================================
+ Coverage    83.84%   83.92%   +0.07%     
===========================================
  Files          170      173       +3     
  Lines        22558    22739     +181     
  Branches      4919     4946      +27     
===========================================
+ Hits         18914    19083     +169     
- Misses        2526     2535       +9     
- Partials      1118     1121       +3     
Flag Coverage Δ
macos-11_Python-3.10 83.84% <93.25%> (?)
macos-11_Python-3.7 83.52% <93.10%> (?)
ubuntu-20.04_Python-3.10 83.83% <93.25%> (+0.07%) ⬆️
ubuntu-20.04_Python-3.7 83.52% <93.10%> (+0.07%) ⬆️
ubuntu-20.04_Python-3.8 83.76% <93.25%> (+0.07%) ⬆️
ubuntu-20.04_Python-3.9 83.77% <93.25%> (+0.07%) ⬆️
windows-2019_Python-3.10 83.80% <93.25%> (+0.06%) ⬆️
windows-2019_Python-3.7 83.49% <93.10%> (+0.07%) ⬆️
windows-2019_Python-3.8 83.72% <93.25%> (+0.07%) ⬆️
windows-2019_Python-3.9 83.74% <93.25%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/annotation.py 92.23% <75.00%> (-0.33%) ⬇️
datumaro/components/media.py 85.84% <85.71%> (+0.32%) ⬆️
datumaro/plugins/tiling/tile.py 94.06% <94.06%> (ø)
datumaro/plugins/tiling/__init__.py 100.00% <100.00%> (ø)
datumaro/plugins/tiling/util.py 100.00% <100.00%> (ø)
datumaro/plugins/splitter.py 88.47% <0.00%> (-0.23%) ⬇️
datumaro/plugins/synthetic_data/utils.py 85.00% <0.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

datumaro/components/media.py Show resolved Hide resolved
datumaro/plugins/tiling/tile.py Outdated Show resolved Hide resolved
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Jan 11, 2023
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim merged commit 6f481cc into openvinotoolkit:develop Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants