Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data explorer feature #773

Merged
merged 36 commits into from
Feb 9, 2023
Merged

Conversation

sooahleex
Copy link
Contributor

Summary

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@sooahleex sooahleex changed the title [Data searcher [WIP] Add data explorer feature Nov 30, 2022
@sooahleex sooahleex force-pushed the data_searcher branch 2 times, most recently from f82d22a to 569e4bd Compare December 6, 2022 08:11
@sooahleex sooahleex changed the title [WIP] Add data explorer feature Add data explorer feature Jan 9, 2023
@sooahleex sooahleex marked this pull request as draft January 9, 2023 14:00
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor reviews.

datumaro/cli/commands/search.py Show resolved Hide resolved
datumaro/cli/commands/search.py Outdated Show resolved Hide resolved
datumaro/cli/commands/search.py Outdated Show resolved Hide resolved
datumaro/components/launcher.py Outdated Show resolved Hide resolved
datumaro/components/searcher.py Outdated Show resolved Hide resolved
datumaro/components/searcher.py Show resolved Hide resolved
tests/assets/searcher/clip_visual_ViT-B_32_interp.py Outdated Show resolved Hide resolved
@sooahleex sooahleex marked this pull request as ready for review January 10, 2023 02:14
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please turn on CI green first.

tests/assets/searcher/clip_ViT-B_32_interp.py Outdated Show resolved Hide resolved
datumaro/plugins/searcher.py Outdated Show resolved Hide resolved
requirements-core.txt Outdated Show resolved Hide resolved
bonhunko
bonhunko previously approved these changes Feb 6, 2023
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thank you!

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2023

Codecov Report

Base: 83.93% // Head: 83.33% // Decreases project coverage by -0.60% ⚠️

Coverage data is based on head (efddbc7) compared to base (3aa4742).
Patch coverage: 29.13% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #773      +/-   ##
===========================================
- Coverage    83.93%   83.33%   -0.60%     
===========================================
  Files          174      179       +5     
  Lines        22941    23236     +295     
  Branches      4973     5022      +49     
===========================================
+ Hits         19255    19364     +109     
- Misses        2559     2743     +184     
- Partials      1127     1129       +2     
Flag Coverage Δ
macos-11_Python-3.10 ?
macos-11_Python-3.7 82.90% <29.13%> (-0.63%) ⬇️
macos-11_Python-3.8 83.18% <29.23%> (-0.60%) ⬇️
macos-11_Python-3.9 83.19% <29.23%> (-0.60%) ⬇️
ubuntu-20.04_Python-3.10 83.25% <29.13%> (-0.60%) ⬇️
ubuntu-20.04_Python-3.7 82.91% <29.13%> (-0.63%) ⬇️
ubuntu-20.04_Python-3.8 83.19% <29.23%> (-0.60%) ⬇️
ubuntu-20.04_Python-3.9 83.20% <29.23%> (-0.60%) ⬇️
windows-2019_Python-3.10 83.21% <29.13%> (-0.61%) ⬇️
windows-2019_Python-3.7 82.86% <29.13%> (-0.64%) ⬇️
windows-2019_Python-3.8 83.13% <29.23%> (-0.60%) ⬇️
windows-2019_Python-3.9 83.15% <29.23%> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/cli/__main__.py 88.77% <ø> (ø)
datumaro/cli/commands/__init__.py 100.00% <ø> (ø)
datumaro/components/hl_ops.py 63.93% <0.00%> (ø)
datumaro/components/searcher.py 13.63% <13.63%> (ø)
datumaro/plugins/searcher.py 20.18% <20.18%> (ø)
datumaro/components/dataset.py 82.33% <33.33%> (-0.68%) ⬇️
...ns/openvino_plugin/samples/clip_ViT-B_32_interp.py 42.85% <42.85%> (ø)
datumaro/cli/commands/search.py 44.44% <44.44%> (ø)
datumaro/util/samples.py 50.00% <50.00%> (ø)
datumaro/components/launcher.py 71.66% <69.23%> (-2.34%) ⬇️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinnamkim vinnamkim added this to the 1.0.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants