Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COCO enable bbox with segement annotation #772

Conversation

bonhunko
Copy link
Contributor

@bonhunko bonhunko commented Nov 30, 2022

Summary

Resolves: CVS-98131

Currently, Datumaro removes the bbox annotations when segmentation annotation exits.
It confused the users and makes a dataset not fit for a detection task.

We thus keep the bbox annotations when importing a COCO dataset.
Then export the bbox annotation and relevant segmentation annotation to single annotation when exporting.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bonhunko bonhunko marked this pull request as ready for review November 30, 2022 00:51
@bonhunko bonhunko force-pushed the feature/coco_enable_bbox_with_segment branch 5 times, most recently from 52b7ccd to 0c81d37 Compare November 30, 2022 06:35
@bonhunko bonhunko changed the title [WIP] COCO enable bbox with segement annotation COCO enable bbox with segement annotation Nov 30, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Base: 83.30% // Head: 83.31% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cbf591e) compared to base (d84c42d).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #772   +/-   ##
========================================
  Coverage    83.30%   83.31%           
========================================
  Files          166      166           
  Lines        22429    22432    +3     
  Branches      4893     4895    +2     
========================================
+ Hits         18685    18689    +4     
+ Misses        2639     2637    -2     
- Partials      1105     1106    +1     
Flag Coverage Δ
macos-10.15_Python-3.10 83.22% <80.00%> (+<0.01%) ⬆️
macos-10.15_Python-3.7 82.90% <80.00%> (+<0.01%) ⬆️
macos-10.15_Python-3.8 83.15% <80.00%> (+<0.01%) ⬆️
macos-10.15_Python-3.9 83.16% <80.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.10 83.24% <80.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.7 82.91% <80.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 83.17% <80.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.9 83.18% <80.00%> (+<0.01%) ⬆️
windows-2019_Python-3.10 83.24% <80.00%> (+<0.01%) ⬆️
windows-2019_Python-3.7 82.91% <80.00%> (+<0.01%) ⬆️
windows-2019_Python-3.8 83.16% <80.00%> (+<0.01%) ⬆️
windows-2019_Python-3.9 83.17% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/data_formats/coco/base.py 91.96% <50.00%> (-0.38%) ⬇️
datumaro/plugins/data_formats/coco/exporter.py 89.50% <100.00%> (+0.04%) ⬆️
datumaro/components/annotation.py 92.55% <0.00%> (+0.46%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bonhunko bonhunko force-pushed the feature/coco_enable_bbox_with_segment branch 4 times, most recently from f96fd8d to 0ba99e1 Compare November 30, 2022 08:12
@bonhunko bonhunko force-pushed the feature/coco_enable_bbox_with_segment branch from 0ba99e1 to cbf591e Compare December 2, 2022 00:23
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bonhunko bonhunko merged commit 28d1da7 into openvinotoolkit:develop Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants