Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An interface to manipulate infos that stores a dataset meta-informations #767

Merged

Conversation

bonhunko
Copy link
Contributor

@bonhunko bonhunko commented Nov 22, 2022

Summary

related ticket: CVS-97082
Implement an interface to manipulate 'infos' that stores a dataset meta-information.
You can add any meta-information you want, such that author, related papers, comments, ...

When you export a dataset to Datumaro format, infos will be stored to annotation json like the bellow:
{
"infos": {
"task": "classification",
"comment": "This dataset is annotated by the human"
},
"categories": {
.....
}

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bonhunko bonhunko force-pushed the feature/implement_info_interface branch 2 times, most recently from 9a4a456 to f038473 Compare November 22, 2022 07:23
@bonhunko bonhunko changed the title An interface to manipulate infos [WIP] An interface to manipulate infos Nov 22, 2022
@bonhunko bonhunko marked this pull request as ready for review November 22, 2022 07:40
@bonhunko bonhunko force-pushed the feature/implement_info_interface branch from f038473 to c3dd9fc Compare November 22, 2022 07:41
@bonhunko bonhunko marked this pull request as draft November 22, 2022 07:42
@bonhunko bonhunko force-pushed the feature/implement_info_interface branch 6 times, most recently from 974b78e to f3fca09 Compare November 23, 2022 06:44
@bonhunko bonhunko marked this pull request as ready for review November 23, 2022 06:52
@bonhunko bonhunko changed the title [WIP] An interface to manipulate infos An interface to manipulate infos that stores a dataset meta-informations Nov 23, 2022
@bonhunko bonhunko force-pushed the feature/implement_info_interface branch 2 times, most recently from 85dc96e to ec46a67 Compare November 23, 2022 07:13
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Base: 84.64% // Head: 84.45% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (ddb932c) compared to base (c5327b3).
Patch coverage: 80.15% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #767      +/-   ##
===========================================
- Coverage    84.64%   84.45%   -0.19%     
===========================================
  Files          157      157              
  Lines        21925    22049     +124     
  Branches      4804     4827      +23     
===========================================
+ Hits         18558    18622      +64     
- Misses        2263     2319      +56     
- Partials      1104     1108       +4     
Flag Coverage Δ
macos-10.15_Python-3.7 ?
macos-10.15_Python-3.8 ?
macos-10.15_Python-3.9 ?
ubuntu-20.04_Python-3.10 84.09% <80.15%> (-0.03%) ⬇️
ubuntu-20.04_Python-3.7 83.79% <79.52%> (-0.02%) ⬇️
ubuntu-20.04_Python-3.8 84.02% <80.15%> (-0.03%) ⬇️
ubuntu-20.04_Python-3.9 84.03% <80.15%> (-0.03%) ⬇️
windows-2019_Python-3.10 84.11% <80.15%> (?)
windows-2019_Python-3.7 83.79% <79.52%> (-0.04%) ⬇️
windows-2019_Python-3.8 84.03% <80.15%> (?)
windows-2019_Python-3.9 84.32% <80.15%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/components/errors.py 87.53% <66.66%> (-0.17%) ⬇️
datumaro/plugins/coco_format/converter.py 89.46% <66.66%> (-0.15%) ⬇️
datumaro/components/launcher.py 74.00% <71.42%> (-0.42%) ⬇️
datumaro/plugins/transforms.py 81.21% <75.00%> (-0.22%) ⬇️
datumaro/components/dataset.py 83.37% <75.47%> (-0.69%) ⬇️
datumaro/plugins/datumaro_format/converter.py 92.82% <83.33%> (-0.29%) ⬇️
datumaro/components/operations.py 84.41% <85.71%> (+0.17%) ⬆️
datumaro/components/extractor.py 82.64% <90.90%> (+0.35%) ⬆️
datumaro/components/extractor_tfds.py 95.81% <100.00%> (+0.10%) ⬆️
datumaro/components/hl_ops.py 63.93% <100.00%> (+0.60%) ⬆️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

datumaro/components/dataset.py Outdated Show resolved Hide resolved
datumaro/components/dataset.py Outdated Show resolved Hide resolved
datumaro/components/launcher.py Show resolved Hide resolved
datumaro/components/operations.py Outdated Show resolved Hide resolved
datumaro/components/operations.py Outdated Show resolved Hide resolved
datumaro/plugins/transforms.py Outdated Show resolved Hide resolved
@bonhunko bonhunko force-pushed the feature/implement_info_interface branch 3 times, most recently from 642e290 to 010e183 Compare November 23, 2022 08:17
@bonhunko bonhunko force-pushed the feature/implement_info_interface branch from 010e183 to ddb932c Compare November 23, 2022 08:20
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bonhunko bonhunko merged commit e3ca3b5 into openvinotoolkit:develop Nov 24, 2022
@bonhunko bonhunko deleted the feature/implement_info_interface branch November 24, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants