Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export as CVAT video format #757

Merged
merged 2 commits into from
Nov 15, 2022

Conversation

bonhunko
Copy link
Contributor

@bonhunko bonhunko commented Nov 7, 2022

Summary

  • Support for exporting as CVAT video format
  • Add 'use_track' option to export DatasetItem into tag
  • Implement CVS-93496
  • e.g.)
    <track id="0" label="label2">
    <box frame="4" occluded="1" outside="0" keyframe="1" xtl="3.00" ytl="4.00" xbr="10.00" ybr="5.00" z_order="0">
    </box>
    .....
    <box frame="14" occluded="1" outside="0" keyframe="1" xtl="3.00" ytl="4.00" xbr="10.00" ybr="5.00" z_order="0">
    </box>
    </track>

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bonhunko bonhunko force-pushed the feature/cvat_video_export branch 3 times, most recently from 16932aa to f4c6400 Compare November 7, 2022 15:58
@bonhunko bonhunko marked this pull request as ready for review November 7, 2022 16:02
datumaro/plugins/cvat_format/converter.py Outdated Show resolved Hide resolved
tests/test_cvat_format.py Outdated Show resolved Hide resolved
tests/test_cvat_format.py Outdated Show resolved Hide resolved
@bonhunko bonhunko force-pushed the feature/cvat_video_export branch 2 times, most recently from 82175ac to ba724d8 Compare November 9, 2022 07:18
vinnamkim
vinnamkim previously approved these changes Nov 9, 2022
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vinnamkim
vinnamkim previously approved these changes Nov 9, 2022
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vinnamkim
vinnamkim previously approved these changes Nov 15, 2022
@bonhunko
Copy link
Contributor Author

I resolve a conflict of CHANGELOG via 8ea3be2 after the review approval. @vinnamkim, would you please give an approval again?

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2022

Codecov Report

Base: 84.20% // Head: 84.20% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8ea3be2) compared to base (1909d85).
Patch coverage: 79.54% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #757   +/-   ##
========================================
  Coverage    84.20%   84.20%           
========================================
  Files          157      157           
  Lines        21855    21925   +70     
  Branches      4779     4804   +25     
========================================
+ Hits         18402    18462   +60     
- Misses        2365     2368    +3     
- Partials      1088     1095    +7     
Flag Coverage Δ
macos-10.15_Python-3.10 84.12% <79.54%> (+<0.01%) ⬆️
macos-10.15_Python-3.7 83.81% <79.54%> (+<0.01%) ⬆️
macos-10.15_Python-3.8 84.05% <79.54%> (+<0.01%) ⬆️
macos-10.15_Python-3.9 84.06% <79.54%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.10 84.12% <79.54%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.7 83.81% <79.54%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 84.05% <79.54%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.9 84.06% <79.54%> (+<0.01%) ⬆️
windows-2019_Python-3.10 84.14% <79.54%> (+<0.01%) ⬆️
windows-2019_Python-3.7 83.83% <79.54%> (+<0.01%) ⬆️
windows-2019_Python-3.8 84.06% <79.54%> (+<0.01%) ⬆️
windows-2019_Python-3.9 84.07% <79.54%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/plugins/cvat_format/converter.py 87.53% <79.54%> (-1.23%) ⬇️
datumaro/plugins/transforms.py 81.43% <0.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wonjuleee wonjuleee merged commit 1f61a48 into openvinotoolkit:develop Nov 15, 2022
wonjuleee pushed a commit to wonjuleee/datumaro that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants