Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Label, Points, Polygon, PolyLine, and Caption visualization features #746

Merged
merged 10 commits into from
Oct 25, 2022
Merged

Add Label, Points, Polygon, PolyLine, and Caption visualization features #746

merged 10 commits into from
Oct 25, 2022

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Oct 19, 2022 •
edited
Loading

Summary

  • Related ticket no. 94413.
  • Add Label, Points, Polygon, PolyLine, and Caption visualization features.
  • Did some code and test code refactoring
Label Points
image image
Polygon and PolyLine Caption
image image

How to test

  • Unit tests are added

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim
Add other visualization features
abf3c9a 
 - Add label, polygon, polyline, and points visualization features

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Update draw_label for multi-label visualization
35e1e21 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add draw_caption
1bba635 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Refactor test_visualizer.py
9c43a75 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add Label, Points, Polygon, PolyLine, and Caption unit tests
787254c 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim changed the title Feature/seg visualizer Add Label, Points, Polygon, PolyLine, and Caption visualization features Oct 19, 2022
@vinnamkim
Fix isort
163fb66 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Fix pylint
0a91b8a 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Add changelog
f8f3c3a 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Fix isort
10ce031 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Fix Python 3.7 unittest error
0086777 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added ENHANCE Enhancement of existing features ready-to-review labels Oct 20, 2022
bonhunko
bonhunko approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vinnamkim vinnamkim mentioned this pull request Oct 20, 2022
Merged
7 tasks
sooahleex
sooahleex approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

wonjuleee
wonjuleee approved these changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@wonjuleee wonjuleee merged commit f69026b into openvinotoolkit:develop Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonjuleee wonjuleee wonjuleee approved these changes

@sooahleex sooahleex sooahleex approved these changes

@bonhunko bonhunko bonhunko approved these changes

@chuneuny-emily chuneuny-emily Awaiting requested review from chuneuny-emily

Assignees
No one assigned
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinnamkim @wonjuleee @sooahleex @bonhunko