Add Bbox visualizer #744
Add Bbox visualizer #744
Conversation
vinnamkim
requested review from
chuneuny-emily,
sooahleex,
wonjuleee and
bonhunko
|
Can you add the short summary and link instead of "related ticket no. 94410"? |
There was a problem hiding this comment.
visualizer.py is a newly created file in components. Please add it in changelog. And please consider to add Dataset visualization category at "How to use Datumaro" in user manual. It's not urgent, so you can update it all at once when other tasks are completed.
datumaro/components/visualizer.py
Outdated
| ncols: int, | ||
| subset: Optional[str] = None, | ||
| ) -> Figure: | ||
| assert nrows > 0, "nrows should be a positive integer." |
There was a problem hiding this comment.
I think that halting the program is not a good idea since the visualizer is 'only for showing' not a core functional logic.
How about just printing error messages and showing empty images when something goes wrong instead of assertion?
There was a problem hiding this comment.
My thought is that this API is mainly target for Jupyter Notebook users. So, if there is a problem, their executions will be failed only at a cell scope. I think it will be okay and giving exception can make users more cautious than printing messages. If this API will be used in Python programs, I believe those intermediate users can sufficiently use try-catch clauses to capture exceptions.
| if ann.type == AnnotationType.bbox: | ||
| self._draw_bbox(ann, label_categories, ax) | ||
| else: | ||
| raise NotImplementedError(f"{ann.type} is not implemented yet.") |
There was a problem hiding this comment.
An exception will stop the program like an assertion.
How about just printing messages in the visualizer?
There was a problem hiding this comment.
Please refer to my above comment.
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
vinnamkim
force-pushed
the
feature/visualizer
branch
from
23a166f
to
f4cfe37
Compare
Documentation is planned for the next work in the future. |
Signed-off-by: Kim, Vinnam vinnam.kim@intel.com
Summary
How to test
Unit tests are updated.
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.