Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NYU Depth Dataset V2 (import-only) #712

Merged
merged 5 commits into from
Apr 5, 2022
Merged

Conversation

yasakova-anastasia
Copy link

@yasakova-anastasia yasakova-anastasia commented Apr 4, 2022

Summary

  • Added NYU Depth Dataset V2 (import-only)
  • Added DepthAnnotation type

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@yasakova-anastasia
Copy link
Author

I'm not sure about the correct use of the annotation type. I don't like that now two different types of annotation are made as one.

One more annotation type DepthAnnotation could be added. But these two annotation types will contain the same thing (image). But in the future there will be no problem when converting from format to format.

@zhiltsov-max
Copy link
Contributor

I like the idea about 2 annotation types. You can inherit both types from the same base type with an image.

@zhiltsov-max zhiltsov-max merged commit 8e029f7 into develop Apr 5, 2022
@zhiltsov-max zhiltsov-max deleted the ay/nyu-depth-v2-format branch April 5, 2022 15:24
for anno_file in anno_files:
item_id = osp.splitext(osp.basename(anno_file))[0]
with h5py.File(anno_file, "r") as f:
image = np.transpose(f["rgb"], (1, 2, 0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is possible that channels need to be inverted to BGR, please check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants