-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve YOLO parsing errors #687
Conversation
3a6bd1e
to
c475735
Compare
if item is not None: | ||
yield item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This enables questionable semantics: if any items are skipped in this way, then the number of items yielded will be different from the value returned by len(subset)
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree about this, but it is not clear how to resolve the problem, and it has very limited ways to impact the situation, because it is only used until the imported dataset is cached. During caching/iteration, the actual count is computed. Actually, in VOC we have the same issue. Maybe, we could even consider it normal, because unless we loaded the data, it is the best we can report.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the proper solution would involve removing __len__
from IExtractor
.
Summary
Depends on #686
.data
fileutil.image.ImageMeta
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.