-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce API v1 #630
Introduce API v1 #630
Conversation
a4673e7
to
1611c23
Compare
1611c23
to
580411e
Compare
return Dataset(source=produced, env=env) | ||
|
||
def filter(dataset: IDataset, expr: str, *, #pylint: disable=redefined-builtin | ||
filter_annotations: bool = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, the fact that different values of this function select completely different implementations suggests that this function should be split into two, filter_items
and filter_annotations
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was done so some time ago, but it wasn't very comfortable to use. I'll reconsider such option.
Summary
Resolves #133
Introduces comfortable library API. For external use, the recommended way to call Datumaro API is:
Dataset
method parameters became kw-onlycomponents.extractor
Remaining:
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.