Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark python 3.6 unsupported #617

Merged
merged 5 commits into from
Jan 11, 2022
Merged

Mark python 3.6 unsupported #617

merged 5 commits into from
Jan 11, 2022

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jan 11, 2022

Summary

Python 3.6 is EOLed, so it's reasonable to discontinue it's support. Moreover, we already use some features of 3.7 (currently, only to make API changes backward-compatible).

  • Changed the minimum required version in setup.py

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@IRDonch
Copy link

IRDonch commented Jan 11, 2022

There are several locations where Python 3.6 is mentioned; they should be updated:

.github/workflows/health_check.yml
11:        python-version: ['3.6', '3.7', '3.8', '3.9']
27:        if: matrix.python-version == '3.6'

.github/workflows/pr_checks.yml
21:        python-version: ['3.6', '3.7', '3.8', '3.9']

site/content/en/docs/contributing.md
17:- Python (3.6+)

site/content/en/docs/getting_started.md
15:- Python (3.6+)

site/content/en/docs/user-manual/installation.md
10:- Python (3.6+)

@zhiltsov-max
Copy link
Contributor Author

Thanks. I'm not sure if we really interested in other changes from the list (https://docs.python.org/3/whatsnew/3.7.html), but I'm open for ideas.

@zhiltsov-max zhiltsov-max merged commit 86cf763 into develop Jan 11, 2022
@zhiltsov-max zhiltsov-max deleted the zm/drop-py36 branch January 11, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants