Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project dataset saving when rpath is used #613

Merged
merged 6 commits into from
Jan 11, 2022

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jan 10, 2022

Summary

Closes #602

  • Changed how dataset path is stored in ProjectDataset to use only the source directory. This follows the logic of how project contains sources and allows to save/export/patch project datasets in essential way.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Roman Donchenko <roman.donchenko@intel.com>
@zhiltsov-max zhiltsov-max merged commit 20d3d74 into develop Jan 11, 2022
@zhiltsov-max zhiltsov-max deleted the zm/fix-windows-makedirs branch January 11, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patch command example error
2 participants