Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line matching in multimerge #592

Merged
merged 14 commits into from
Dec 22, 2021
Merged

Fix line matching in multimerge #592

merged 14 commits into from
Dec 22, 2021

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Dec 21, 2021

Summary

Closes #219

  • Renamed smooth_line to approximate_line, added deprecation notice
  • Added more descriptions and type annotations
  • The function now always returns only a single array
  • Updated implementation of the line comparison algorithm
  • Fixed the problem when multimerge failed because of missing label categories
  • Fixed area computation in case of self-intersections

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

datumaro/components/operations.py Outdated Show resolved Hide resolved
datumaro/util/annotation_util.py Outdated Show resolved Hide resolved
datumaro/util/annotation_util.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@IRDonch IRDonch merged commit 4b53be7 into develop Dec 22, 2021
@IRDonch IRDonch deleted the zm/fix-line-matching branch December 22, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return format is not uniform
2 participants