Add a dedicated command to detect a dataset's format #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
added 8 commits
January 21, 2022 14:50
There is actually very little in this code that deals with environments, and this move makes it possible to reuse the code for other purposes.
This will allow verbose reporting of format detection outcomes.
I don't think it's actually necessary to report different rejection reasons via different methods, given how similar they are represented in the JSON report. If we ever need to pass custom data for different reasons, we can modify the callback / add a new one.
zhiltsov-max
previously approved these changes
Jan 24, 2022
added 3 commits
January 24, 2022 19:12
`__str__` is the typical way to report exception messages, and I don't see a compelling reason not to use it here. Also, change the `human_message` parameter of `RejectionCallback` to an `str`, since there's no real need to report the message as a sequence of lines rather than as a multiline string. Also, with the sequence representation, it was possible to produce a line with a `\n` in the middle, which is undesirable. A single multiline string is not susceptible to this.
Also, rename the `detectors` parameter to `formats`, since that's a better representation of its semantics.
I think the old name was derived from a class name that is no longer used. It's irrelevant now.
zhiltsov-max
previously approved these changes
Jan 24, 2022
zhiltsov-max
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
How to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.