Add detection support for 4 more formats #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 16, 2021 20:20
* lfw * open_images * vgg_face2 * widerface
|
|
||
| def fail(self, requirement: str) -> NoReturn: | ||
| """ | ||
| Places a requirement that is never met. `requirement` must contain | ||
| a human-readable description of the requirement. | ||
| """ | ||
| self._start_requirement() | ||
| self._start_requirement("fail") |
There was a problem hiding this comment.
"a requirement ('fail') can't be placed directly within an 'alternatives' block"
Still sound strange, IMO. Not a blocker, anyway.
There was a problem hiding this comment.
🤷♂️ It's a message for developers. I think they can figure it out.
added 2 commits
November 18, 2021 13:11
The new name more directly represents what the function does, and is less visually similar to `alternatives`.
This kind of value is called `requirement_desc` elsewhere.
zhiltsov-max
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The formats in question are
lfw,open_images,vgg_face2andwiderface. As supporting infrastructure, add alternative requirement support.Also, add low-level format detection tests, which I should really have done earlier.
How to test
Checklist
developbranchLicense
Feel free to contact the maintainers if that's a concern.