Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an invalid call to pycocotools.mask.iou #450

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix an invalid call to pycocotools.mask.iou #450

merged 1 commit into from
Sep 7, 2021

Conversation

IRDonch
Copy link

@IRDonch IRDonch commented Sep 7, 2021

Summary

The pyiscrowd parameter is supposed to have the same length as gt, which in this case is 1, not 2. This mistake used to be harmless, but an assert for this was added in the upstream repository (see ppwwyyxx/cocoapi@4f034008), so if a new release of pycocotools comes out, the current version will start crashing.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

The `pyiscrowd` parameter is supposed to have the same length as `gt`, which
in this case is 1, not 2. This mistake used to be harmless, but an assert
for this was added in the upstream repository (see
ppwwyyxx/cocoapi@4f034008), so if a new release of pycocotools comes out,
the current version will start crashing.
@zhiltsov-max zhiltsov-max merged commit 698a82b into openvinotoolkit:develop Sep 7, 2021
@IRDonch IRDonch deleted the iou-fix branch September 29, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants