Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix attributes casting for CVAT format #403

Merged
merged 5 commits into from
Aug 10, 2021

Conversation

sizov-kirill
Copy link

Summary

Fixed #395.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max
Copy link
Contributor

Add a test for number attributes, now there is no such tests.

@sizov-kirill
Copy link
Author

Add a test for number attributes, now there is no such tests.

I changed my solution, deleted number type because to fully support it we need to implement data model for attributes.

@zhiltsov-max
Copy link
Contributor

So what about the test? I don't see how your comment is related to this.

zhiltsov-max
zhiltsov-max previously approved these changes Aug 10, 2021
@zhiltsov-max
Copy link
Contributor

Please update the changelog

@zhiltsov-max zhiltsov-max merged commit d75c234 into develop Aug 10, 2021
@zhiltsov-max zhiltsov-max deleted the sk/fix-attributes-casting branch August 10, 2021 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cvat_format/extractor type casting value to float, causing issues
2 participants