-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI on Windows #392
Add CI on Windows #392
Conversation
python-version: ['3.6', '3.7', '3.8', '3.9'] | ||
runs-on: ubuntu-latest | ||
exclude: | ||
# pycocotools-windows doesn't have a wheel for Python 3.9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a wheel? We should be able to build from sources with Cython. 3.9 looks like a thing we need to support (for example, ubuntu 21.04 already uses it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pycocotools-windows
doesn't have sources either.
I considered switching to pycocotools
for Python >=3.9, but that doesn't build on Windows prior to version 2.0.2, which we have disabled.
I just realized I forgot to add a changelog entry. WIll do so shortly. |
Summary
Add Windows CI builds and fix/work around any issues that they found.
How to test
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.