Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI on Windows #392

Merged
merged 7 commits into from
Aug 3, 2021
Merged

Add CI on Windows #392

merged 7 commits into from
Aug 3, 2021

Conversation

IRDonch
Copy link

@IRDonch IRDonch commented Jul 29, 2021

Summary

Add Windows CI builds and fix/work around any issues that they found.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@IRDonch IRDonch marked this pull request as ready for review July 30, 2021 18:05
python-version: ['3.6', '3.7', '3.8', '3.9']
runs-on: ubuntu-latest
exclude:
# pycocotools-windows doesn't have a wheel for Python 3.9
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need a wheel? We should be able to build from sources with Cython. 3.9 looks like a thing we need to support (for example, ubuntu 21.04 already uses it).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pycocotools-windows doesn't have sources either.

I considered switching to pycocotools for Python >=3.9, but that doesn't build on Windows prior to version 2.0.2, which we have disabled.

@IRDonch
Copy link
Author

IRDonch commented Aug 2, 2021

I just realized I forgot to add a changelog entry. WIll do so shortly.

@IRDonch IRDonch marked this pull request as draft August 2, 2021 11:50
@IRDonch IRDonch marked this pull request as ready for review August 2, 2021 12:28
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@zhiltsov-max zhiltsov-max merged commit b51a12b into openvinotoolkit:develop Aug 3, 2021
@IRDonch IRDonch deleted the win-ci branch August 4, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants