Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return full image paths in ImageNet item ids #371

Merged
merged 11 commits into from
Jul 22, 2021

Conversation

sizov-kirill
Copy link

@sizov-kirill sizov-kirill commented Jul 20, 2021

Summary

Resolved #336 by changing id for items.

How to test

Import the original ImageNet dataset with Datumaro.

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please check is the original dataset contains the same images in different directories? You can use operations.find_unique_images().

Maybe, we should append the label directory in front of the item id as well as in other formats?

@sizov-kirill
Copy link
Author

sizov-kirill commented Jul 21, 2021

Could you please check is the original dataset contains the same images in different directories? You can use operations.find_unique_images().

Maybe, we should append the label directory in front of the item id as well as in other formats?

@zhiltsov-max I checked, the original dataset has the same images in different directories but all of them have different names.

I don't think that is a need to add the label directory in front of the item id, because images in the directories have name label_xxxx.jpg (in the original dataset).

zhiltsov-max
zhiltsov-max previously approved these changes Jul 21, 2021
@zhiltsov-max
Copy link
Contributor

Please fix the remaining test

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the changelog

@zhiltsov-max zhiltsov-max merged commit 422de44 into develop Jul 22, 2021
@zhiltsov-max zhiltsov-max changed the title Fix imagenet importer Return full image paths in ImageNet item ids Jul 26, 2021
@zhiltsov-max zhiltsov-max deleted the sk/fix-imagenet-importer branch August 19, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Import ImageNet dataset
2 participants