-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return full image paths in ImageNet item ids #371
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check is the original dataset contains the same images in different directories? You can use operations.find_unique_images()
.
Maybe, we should append the label directory in front of the item id as well as in other formats?
@zhiltsov-max I checked, the original dataset has the same images in different directories but all of them have different names. I don't think that is a need to add the label directory in front of the item id, because images in the directories have name |
Please fix the remaining test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the changelog
Summary
Resolved #336 by changing id for items.
How to test
Import the original ImageNet dataset with Datumaro.
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.