Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVAT-3D Milestone-6 PCD and Kitti formats #245

Closed
wants to merge 40 commits into from

Conversation

manasars
Copy link

Added feature for supporting import and export of PCD and Kitti format files in CVAT.

  • I submit my changes into the develop branch
  • I have added description of my changes into CHANGELOG

License

  • I submit my code changes under the same MIT License that covers the project.

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

datumaro/plugins/coco_format/__init__.py Outdated Show resolved Hide resolved
datumaro/plugins/pointcloud_format/__init__.py Outdated Show resolved Hide resolved
datumaro/plugins/pointcloud_format/converter.py Outdated Show resolved Hide resolved
datumaro/plugins/pointcloud_format/converter.py Outdated Show resolved Hide resolved
datumaro/plugins/pointcloud_format/extractor.py Outdated Show resolved Hide resolved
datumaro/plugins/pointcloud_format/extractor.py Outdated Show resolved Hide resolved
datumaro/plugins/pointcloud_format/extractor.py Outdated Show resolved Hide resolved
datumaro/plugins/pointcloud_format/extractor.py Outdated Show resolved Hide resolved
datumaro/plugins/pointcloud_format/extractor.py Outdated Show resolved Hide resolved
@manasars
Copy link
Author

manasars commented May 22, 2021

@zhiltsov-max

Copy link
Contributor

@zhiltsov-max zhiltsov-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reduce the size of tests/assets/velodynepoint_dataset/velodyne_points/data/000001.pcd? It is 1+ MB, I suppose we can create a more lightweight alternative for tests.

tests/assets/pointcloud_dataset/meta.json Outdated Show resolved Hide resolved
datumaro/components/extractor.py Outdated Show resolved Hide resolved
datumaro/components/extractor.py Outdated Show resolved Hide resolved
datumaro/plugins/velodynepoints_format/format.py Outdated Show resolved Hide resolved
@manasars
Copy link
Author

@zhiltsov-max Updated Tests as well.

@zhiltsov-max
Copy link
Contributor

Can we do something about big files in tests? They increase repository size, they are hard to verify and maintain, and they don't seem to be really used.

@manasars
Copy link
Author

Can we do something about big files in tests? They increase repository size, they are hard to verify and maintain, and they don't seem to be really used.

Working on the same

@zhiltsov-max
Copy link
Contributor

Ok, then we merge this PR, once CVAT part is approved.

attr_value = 'true' if attr_value else 'false'
if self._context._allow_undeclared_attrs or \
attr_name in self._get_label_attrs(item.label):
continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attributes need to be written.

@zhiltsov-max
Copy link
Contributor

zhiltsov-max commented Jun 9, 2021

Summary:

  • Support writing and reading dataset subsets in the new formats
  • Support (fix) writing attributes in the new formats
  • Support writing and reading of builtin attributes in new formats (occluded, truncated etc.)
  • Update tests with annotations

.vscode/settings.json Outdated Show resolved Hide resolved
@nmanovic
Copy link

@zhiltsov-max , could you please review the PR once again? If it doesn't have critical issues, please merge it today.

@zhiltsov-max zhiltsov-max mentioned this pull request Jun 29, 2021
9 tasks
@zhiltsov-max
Copy link
Contributor

Covered by #320. Please update CVAT part correspondingly. Label and tag color information is not required in the supervisely format. Attributes are supported. Cuboid tracks are supported (they require track_id annotation attribute - like other tracks in the KITTI format and object annotation attribute in the supervisely format).

@jayraj-solanki
Copy link
Contributor

Hi @zhiltsov-max,

Label and tag color information is not required in the supervisely format

Label and tag color information is tracked in supervisely.
Also we checked downloading the latest annotations in supervisely, the color parameter is present

Attributes are supported

Implemented in CVAT

Cuboid tracks are supported

Since Tracks is out-of-scope in 3D as per SOW, Cuboid tracks isn't implemented.

Is there any changes required from us?

@zhiltsov-max
Copy link
Contributor

zhiltsov-max commented Jul 8, 2021

Label and tag color information is tracked in supervisely.
Also we checked downloading the latest annotations in supervisely, the color parameter is present

I know. What I'm saying is that it is not mandatory.

Is there any changes required from us?

Adapt the CVAT part of the M6 PR. Maybe, there will be some gaps - please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants