-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CVAT-3D Milestone-6 PCD and Kitti formats #245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix license headers: remove them from empty
__init__.py
files. Add correct headers to new code files. - Fix the formatting - keep 80 chars per line, remove unnecessary empty lines, use +1 level of indentation in line continuations
- Add tests on new formats
- Add docs for new formats ( like here https://github.com/openvinotoolkit/datumaro/tree/develop/docs/formats)
- Add examples of datasets in new formats (like here https://github.com/openvinotoolkit/datumaro/tree/develop/tests/assets)
- Really add a line in CHANGELOG.md
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reduce the size of tests/assets/velodynepoint_dataset/velodyne_points/data/000001.pcd
? It is 1+ MB, I suppose we can create a more lightweight alternative for tests.
@zhiltsov-max Updated Tests as well. |
Can we do something about big files in tests? They increase repository size, they are hard to verify and maintain, and they don't seem to be really used. |
Working on the same |
Ok, then we merge this PR, once CVAT part is approved. |
attr_value = 'true' if attr_value else 'false' | ||
if self._context._allow_undeclared_attrs or \ | ||
attr_name in self._get_label_attrs(item.label): | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attributes need to be written.
…into cvat-3D-M6-pcd
Summary:
|
…into cvat-3D-M6-pcd
…into cvat-3D-M6-pcd
@zhiltsov-max , could you please review the PR once again? If it doesn't have critical issues, please merge it today. |
Covered by #320. Please update CVAT part correspondingly. Label and tag color information is not required in the supervisely format. Attributes are supported. Cuboid tracks are supported (they require |
Hi @zhiltsov-max,
Label and tag color information is tracked in supervisely.
Implemented in CVAT
Since Tracks is out-of-scope in 3D as per SOW, Cuboid tracks isn't implemented. Is there any changes required from us? |
I know. What I'm saying is that it is not mandatory.
Adapt the CVAT part of the M6 PR. Maybe, there will be some gaps - please let me know. |
Added feature for supporting import and export of PCD and Kitti format files in CVAT.
develop
branchLicense