-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ndr cli #178
Add ndr cli #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix tests
bugfix - memory error
550ea66
to
5cea446
Compare
Squashed all commit into one and delete not related to issue |
|
||
result = ndr.NDR(source, working_subset='train', seed=12145) | ||
|
||
self.assertEqual(2, len(result.get_subset("train"))) | ||
self.assertEqual(298, len(result.get_subset("duplicated"))) | ||
self.assertEqual(1, len(result.get_subset("train"))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why it was changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After changing default block shape from (4,4) to (8,8), there was change in train and duplicated subset length
Summary
This pr includes :
How to test
python -m unittest -v tests/test_ndr.py
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.