Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary image loading in Datumaro format on save #176

Merged
merged 7 commits into from
Mar 22, 2021

Conversation

zhiltsov-max
Copy link
Contributor

Summary

  • Fixed the problem with occasional image loading in Datumaro format

The problem is that transforms for inputs, providing no image metainfo (size etc.), can require image loading for loading size data. Unless image saving is not required, it should not be done.

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max zhiltsov-max linked an issue Mar 19, 2021 that may be closed by this pull request
@jihyeonyi
Copy link
Contributor

It works well in the classification_split.

@zhiltsov-max zhiltsov-max merged commit a572846 into develop Mar 22, 2021
@zhiltsov-max zhiltsov-max deleted the zm/avoid-unnecessary-image-loading branch March 22, 2021 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dataset saving can lead to unnecessary image loading
2 participants