-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validator for classification & detection tasks #160
Conversation
…e datumaro.components.error, simplified unittest
I think, it would be useful to add item subset as well (or group results by subsets)
looks quite strange for 'x' and 'y' bbox attributes - why images in the dataset must have anything common for them? 'width' and 'height' are more or less understandable, but it might be good to check against clusters, instead of a single value of average. Another thought is to allow setting acceptable boundaries.
should consider attributes in LabelCategories.attributes as general, i.e. applicable to all labels. Label-specific ones are written in each label.
|
For the 2nd comment (grouping missing bbox cases), your idea seems really nice but I don't think we can apply the groupping function at this PR. |
For 3rd comment, I agree with you. For 4rd comment, we didn't know that. Seongjun would fix that. And for the last comment, we'll consider that later, because it is a design issue. |
…tes to include shared attributes.
I've addressed 3rd and 4th comments in my most recent commit. |
I mean, it would simplify/clarify things, if error messages contained a "subset" field, because a single id can (theoretically) be found in several subsets. And even if subsets do not have same item ids, it still makes the process of error localization simpler. { |
Oh, I can understand now. It's not difficult to add "subset" information and it seems useful. |
Added the subset field to the error messages! |
Summary
This PR includes:
How to test
python -m unittest -v tests/test_validator.py
Checklist
develop
branchLicense
Feel free to contact the maintainers if that's a concern.