Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hierarchical structure for ImageNet format #1562

Merged

Conversation

itrushkin
Copy link
Contributor

Duplicate of #1528 but with releases/1.8.0 base.

<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary
CVS-143460
<!--
Resolves openvinotoolkit#111 and openvinotoolkit#222.
Depends on openvinotoolkit#1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem openvinotoolkit#1234
-->

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [x] I have added unit tests to cover my changes.​
- [ ] I have added integration tests to cover my changes.​
- [ ] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [ ] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [x] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [ ] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```

---------

Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin itrushkin requested review from a team as code owners July 10, 2024 07:56
@itrushkin itrushkin requested review from jihyeonyi and removed request for a team July 10, 2024 07:56
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (releases/1.8.0@4ae4326). Learn more about missing BASE report.

Files Patch % Lines
src/datumaro/plugins/data_formats/imagenet.py 78.72% 3 Missing and 7 partials ⚠️
src/datumaro/plugins/data_formats/image_dir.py 83.33% 1 Missing and 2 partials ⚠️
src/datumaro/plugins/data_formats/yolo/exporter.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             releases/1.8.0    #1562   +/-   ##
=================================================
  Coverage                  ?   81.04%           
=================================================
  Files                     ?      276           
  Lines                     ?    32408           
  Branches                  ?     6590           
=================================================
  Hits                      ?    26265           
  Misses                    ?     4691           
  Partials                  ?     1452           
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.02% <80.00%> (?)
windows-2022_Python-3.10 81.02% <80.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chuneuny-emily chuneuny-emily merged commit b2b8533 into openvinotoolkit:releases/1.8.0 Jul 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants