verify w and h input multiplication overflow to rleEncode() #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyeonyi
reviewed
Jun 27, 2024
| siz j, k, a = w * h; | ||
|
|
||
| if (a / w != h) |
There was a problem hiding this comment.
Shouldn't we also check for cases where 'w' is 0? And if a/w results in a floating-point value, we shouldn't compare it using !=.
There was a problem hiding this comment.
@jihyeonyi w and h would be passed from the size of numpy 2d array so i think it would be verified while initializing 2d array. and this function will not be exposed directly to the python.
jihyeonyi
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To apply same changes of #1544 to 1.8.0
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.