Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video bug fix #1547

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Jun 26, 2024

Summary

Resolves 145146 and 145169 for datumaro format.

  • 145146
    • When exporting a video several times, it should be saved only once to prevent the video from being overwritten.
  • 145169
    • Exported video paths should be relative from videos/<subset> directory.

How to test

Tests are automatically done by tests in tests/unit/data_formats/datumaro/test_datumaro_format.py.

  • Test for 145146: test_export_video_only_once
  • Test for 145169: test_can_save_and_load

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi marked this pull request as ready for review June 27, 2024 02:30
@jihyeonyi jihyeonyi requested review from a team as code owners June 27, 2024 02:30
@jihyeonyi jihyeonyi requested review from wonjuleee and removed request for a team June 27, 2024 02:30
@jihyeonyi jihyeonyi added this to the 1.8.0 milestone Jun 27, 2024
@jihyeonyi jihyeonyi added the BUG Something isn't working label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 14 lines in your changes missing coverage. Please review.

Please upload report for BASE (releases/1.8.0@bd87793). Learn more about missing BASE report.

Current head 4caf468 differs from pull request most recent head d82e3c8

Please upload reports for the commit d82e3c8 to get more accurate results.

Files Patch % Lines
src/datumaro/plugins/data_formats/imagenet.py 78.72% 3 Missing and 7 partials ⚠️
src/datumaro/plugins/data_formats/image_dir.py 83.33% 1 Missing and 2 partials ⚠️
src/datumaro/plugins/data_formats/yolo/exporter.py 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             releases/1.8.0    #1547   +/-   ##
=================================================
  Coverage                  ?   81.04%           
=================================================
  Files                     ?      276           
  Lines                     ?    32408           
  Branches                  ?     6590           
=================================================
  Hits                      ?    26265           
  Misses                    ?     4691           
  Partials                  ?     1452           
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.02% <81.81%> (?)
windows-2022_Python-3.10 81.02% <81.81%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jihyeonyi jihyeonyi changed the base branch from develop to releases/1.8.0 June 28, 2024 00:26
Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jihyeonyi jihyeonyi force-pushed the jihyeony/datumaro_video_bug_fix branch from 4caf468 to d82e3c8 Compare June 28, 2024 02:12
@jihyeonyi jihyeonyi merged commit 6e66fd7 into openvinotoolkit:releases/1.8.0 Jun 28, 2024
5 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/datumaro_video_bug_fix branch June 28, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants