Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix when end_frame is zero #1541

Merged

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Jun 19, 2024

Summary

Ticket Number: 144505
When video end_frame is zero, it was saved as None, not 0.
Due to this, end_frame information was lost when exporting it.

How to test

  1. Make a video media with start_frame=0 and end_frame=0
    item = dm.DatasetItem(..., media=Video('video.mp4', start_frame=0, end_frame=0), ...)
    
  2. export the dataset as datumaro format
  3. check it the end_frame is described in the output json file
    ex.
    {
        "id": "video",
        ...,
        "video": {
            "path": "video.mp4",
            "step": 1,
            "start_frame": 0,
            "end_frame": 0
        }
    },
    

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi requested review from a team as code owners June 19, 2024 06:17
@jihyeonyi jihyeonyi requested review from sooahleex and removed request for a team June 19, 2024 06:17
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (63da2ff) to head (9b42bc4).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1541   +/-   ##
========================================
  Coverage    81.05%   81.05%           
========================================
  Files          276      276           
  Lines        32359    32359           
  Branches      6575     6575           
========================================
  Hits         26230    26230           
  Misses        4684     4684           
  Partials      1445     1445           
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.05% <100.00%> (ø)
windows-2022_Python-3.10 81.03% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jihyeonyi jihyeonyi merged commit 58e1582 into openvinotoolkit:develop Jun 19, 2024
8 checks passed
@jihyeonyi jihyeonyi added this to the 1.8.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants