Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Keyword Argument to TabularDataBase #1522

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Jun 5, 2024

Summary

  • Pass kwargs to TabularDataBase during importing dataset
  • It could contain any arguments like encoding

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex force-pushed the enhance/pass_keyword_arguments_tabular_database branch from 6d14549 to 52c9c03 Compare June 5, 2024 01:01
@sooahleex sooahleex marked this pull request as ready for review June 5, 2024 01:03
@sooahleex sooahleex requested review from a team as code owners June 5, 2024 01:03
@sooahleex sooahleex requested review from wonjuleee and removed request for a team June 5, 2024 01:03
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.87%. Comparing base (44cc56a) to head (e8067f8).
Report is 70 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1522      +/-   ##
===========================================
+ Coverage    80.85%   80.87%   +0.01%     
===========================================
  Files          271      275       +4     
  Lines        30689    31857    +1168     
  Branches      6197     6442     +245     
===========================================
+ Hits         24815    25765     +950     
- Misses        4489     4664     +175     
- Partials      1385     1428      +43     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.86% <100.00%> (+0.02%) ⬆️
windows-2022_Python-3.10 80.85% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wonjuleee wonjuleee merged commit 6a05715 into openvinotoolkit:develop Jun 7, 2024
9 checks passed
@sooahleex sooahleex added this to the 1.8.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants