Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clean Transform for tabular data type #1520

Merged

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Jun 4, 2024

Summary

How to test

  • Add unit test for Clean Transform

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex force-pushed the feat/clean_tabular_transfrom branch from 93c9781 to 35c309c Compare June 4, 2024 05:48
src/datumaro/plugins/transforms.py Fixed Show fixed Hide fixed
src/datumaro/plugins/transforms.py Fixed Show fixed Hide fixed
src/datumaro/plugins/transforms.py Fixed Show fixed Hide fixed
src/datumaro/plugins/transforms.py Fixed Show fixed Hide fixed
@sooahleex sooahleex force-pushed the feat/clean_tabular_transfrom branch 2 times, most recently from c340b52 to dd6e5b0 Compare June 11, 2024 06:02
@sooahleex sooahleex marked this pull request as ready for review June 11, 2024 06:03
@sooahleex sooahleex requested review from a team as code owners June 11, 2024 06:03
@sooahleex sooahleex requested review from wonjuleee and removed request for a team June 11, 2024 06:03
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 81.30081% with 23 lines in your changes missing coverage. Please review.

Project coverage is 80.92%. Comparing base (44cc56a) to head (80ded5d).
Report is 72 commits behind head on develop.

Files Patch % Lines
src/datumaro/plugins/transforms.py 78.84% 18 Missing and 4 partials ⚠️
src/datumaro/components/media.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1520      +/-   ##
===========================================
+ Coverage    80.85%   80.92%   +0.06%     
===========================================
  Files          271      276       +5     
  Lines        30689    32212    +1523     
  Branches      6197     6530     +333     
===========================================
+ Hits         24815    26069    +1254     
- Misses        4489     4698     +209     
- Partials      1385     1445      +60     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.92% <81.30%> (+0.07%) ⬆️
windows-2022_Python-3.10 80.90% <81.30%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sooahleex sooahleex merged commit a7a3579 into openvinotoolkit:develop Jun 13, 2024
8 checks passed
@sooahleex sooahleex added this to the 1.8.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants