Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split video directory by subset in datumaro format. #1485

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Apr 30, 2024

Summary

  • ticket No.: 137978

According to the datumaro documentation, video directory is not separated by subset.
image

So a video will be overwritten if it has a duplicated filename in other subset.

Following example has two subsets, train and val, and both subsets have Video_0.avi, ..., Video_9.avi.
So the videos in the train subset is overwritten by the videos in the val subset.
image

So I'd like to split the video directory by subset to avoid this situation.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi requested review from a team as code owners April 30, 2024 02:31
@jihyeonyi jihyeonyi requested review from vinnamkim and removed request for a team April 30, 2024 02:31
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.76%. Comparing base (44cc56a) to head (aa81248).
Report is 49 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1485      +/-   ##
===========================================
- Coverage    80.85%   80.76%   -0.10%     
===========================================
  Files          271      272       +1     
  Lines        30689    31179     +490     
  Branches      6197     6283      +86     
===========================================
+ Hits         24815    25183     +368     
- Misses        4489     4584      +95     
- Partials      1385     1412      +27     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.74% <100.00%> (-0.10%) ⬇️
windows-2022_Python-3.10 80.74% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but is there any modification required for datumaro importer for videos?
One more question, considering the fact that a video could be huge, this change needs more storages (2 twice at the worst case). Do you have any reason to save duplicated videos for each subset?

@wonjuleee wonjuleee merged commit 63d544f into openvinotoolkit:develop Apr 30, 2024
8 checks passed
@jihyeonyi
Copy link
Contributor Author

LGTM, but is there any modification required for datumaro importer for videos? One more question, considering the fact that a video could be huge, this change needs more storages (2 twice at the worst case). Do you have any reason to save duplicated videos for each subset?

I have modified the import, too. Basic assumption is that a video isn't shared by subsets. So there shouldn't be duplicated videos. However, if this assumption is too string, than we need another workaround to save videos.

@jihyeonyi jihyeonyi deleted the jihyeony/split_video_directory_by_subset branch April 30, 2024 04:56
@wonjuleee wonjuleee added this to the 1.7.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants