Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get target information for tabular dataset #1471

Merged
merged 15 commits into from
Apr 25, 2024

Conversation

sooahleex
Copy link
Contributor

@sooahleex sooahleex commented Apr 23, 2024

Summary

  • Set target as dictionary to get input and output column. ex. {"input": "question", "output":["rating", "sentiment"]}

  • If target is None, bring all columns

  • Set input of target column as media and output of it as annotations

    • For example, if we set target as {"input": "length(m)", "output": ["breed_category", "pet_category"]}
      image
      And each item for train and test subset is like below.
      image
      Test file did not have column for breed_category and pet_category, so test subset did not have any annotations.
  • Set CategoricalDtype for column which have dtype as object but that could be used as label. For this, we should define the threshold.

How to test

  • Fix target for unit test and cli test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sooahleex sooahleex marked this pull request as ready for review April 23, 2024 05:22
@sooahleex sooahleex requested review from a team as code owners April 23, 2024 05:22
@sooahleex sooahleex requested review from jihyeonyi and removed request for a team April 23, 2024 05:22
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 80.99%. Comparing base (44cc56a) to head (cc163a6).
Report is 37 commits behind head on develop.

Files Patch % Lines
src/datumaro/plugins/data_formats/tabular.py 82.05% 3 Missing and 4 partials ⚠️
src/datumaro/components/media.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1471      +/-   ##
===========================================
+ Coverage    80.85%   80.99%   +0.14%     
===========================================
  Files          271      272       +1     
  Lines        30689    31242     +553     
  Branches      6197     6294      +97     
===========================================
+ Hits         24815    25306     +491     
- Misses        4489     4519      +30     
- Partials      1385     1417      +32     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.98% <79.54%> (+0.13%) ⬆️
windows-2022_Python-3.10 80.97% <79.54%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sooahleex sooahleex merged commit f9a25f5 into openvinotoolkit:develop Apr 25, 2024
7 of 8 checks passed
@wonjuleee wonjuleee added this to the 1.7.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants