Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new annotation type RotatedBbox #1459

Merged
merged 8 commits into from
Apr 22, 2024

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Apr 19, 2024

Summary

Add a new RotatedBbox annotation type for detection_rotated task.
This provides from_polygon and as_polygon methods for converting set of coordinates to (cx, cy, w, h, r).

This updates the RoboflowYoloObb behavior as a detection_rotated task.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners April 19, 2024 00:35
@wonjuleee wonjuleee requested review from itrushkin and removed request for a team April 19, 2024 00:35
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 90.27778% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 81.01%. Comparing base (44cc56a) to head (6f79643).
Report is 34 commits behind head on develop.

Files Patch % Lines
src/datumaro/components/annotation.py 88.13% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1459      +/-   ##
===========================================
+ Coverage    80.85%   81.01%   +0.15%     
===========================================
  Files          271      272       +1     
  Lines        30689    31215     +526     
  Branches      6197     6286      +89     
===========================================
+ Hits         24815    25289     +474     
- Misses        4489     4511      +22     
- Partials      1385     1415      +30     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 80.99% <90.27%> (+0.14%) ⬆️
windows-2022_Python-3.10 80.98% <90.27%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tests/unit/test_annotation.py Outdated Show resolved Hide resolved
src/datumaro/components/annotation.py Outdated Show resolved Hide resolved
tests/unit/data_formats/test_roboflow.py Outdated Show resolved Hide resolved
@wonjuleee wonjuleee merged commit e0657d8 into openvinotoolkit:develop Apr 22, 2024
8 checks passed
@wonjuleee wonjuleee added this to the 1.7.0 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants