-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify numpy dependency constraint #1435
Modify numpy dependency constraint #1435
Conversation
requirements-core.txt
Outdated
@@ -6,7 +6,7 @@ lxml==5.2.0 | |||
matplotlib>=3.3.1 | |||
networkx>=2.6 | |||
nibabel>=3.2.1 | |||
numpy==1.26.4 | |||
numpy<=1.23.5,>=1.23.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason for having this range?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wonjuleee just a mistake. i've updated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## releases/1.6.0 #1435 +/- ##
=================================================
Coverage ? 80.76%
=================================================
Files ? 271
Lines ? 30713
Branches ? 6203
=================================================
Hits ? 24804
Misses ? 4510
Partials ? 1399
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -6,7 +6,7 @@ lxml==5.2.0 | |||
matplotlib>=3.3.1 | |||
networkx>=2.6 | |||
nibabel>=3.2.1 | |||
numpy==1.26.4 | |||
numpy<2,>=1.23.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before 017b524, numpy version was >=1.17.3
. Is there any reason to increase this to 1.23.4
?
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.