Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable image backend and color channel format to be selectable #1246

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jan 19, 2024

Summary

  • Previously we enabled the image decoding context managing only for both 3-channel colors or unchanged. However, we should extend it to image backend; and RGB or BGR color channel format selection for OTX use cases.

How to test

I updated the existing unit tests to cover this change as well.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim changed the title Enable color channel format selection Enable image decoder and color channel format selection Jan 19, 2024
@vinnamkim vinnamkim changed the title Enable image decoder and color channel format selection Enable image backend and color channel format selection Jan 19, 2024
@vinnamkim vinnamkim changed the title Enable image backend and color channel format selection Enable image backend and color channel format to be selectable Jan 19, 2024
@vinnamkim vinnamkim force-pushed the add-bgr-format branch 3 times, most recently from 957c9f4 to d90f158 Compare January 19, 2024 09:03
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review January 22, 2024 00:36
@vinnamkim vinnamkim requested review from a team as code owners January 22, 2024 00:36
@vinnamkim vinnamkim requested review from wonjuleee and removed request for a team January 22, 2024 00:36
Copy link

@MarkByun MarkByun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (eb44355) 80.53% compared to head (3324d96) 80.53%.
Report is 3 commits behind head on develop.

Files Patch % Lines
src/datumaro/util/image.py 89.36% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1246      +/-   ##
===========================================
- Coverage    80.53%   80.53%   -0.01%     
===========================================
  Files          270      270              
  Lines        30232    30248      +16     
  Branches      5898     5907       +9     
===========================================
+ Hits         24348    24360      +12     
- Misses        4506     4507       +1     
- Partials      1378     1381       +3     
Flag Coverage Δ
ubuntu-20.04_Python-3.8 80.51% <89.36%> (-0.01%) ⬇️
windows-2022_Python-3.8 80.50% <89.36%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim merged commit 895bf4c into openvinotoolkit:develop Jan 23, 2024
5 checks passed
@vinnamkim vinnamkim deleted the add-bgr-format branch January 23, 2024 02:08
@yunchu yunchu added this to the 2.0.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants