Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filtering skill up page #1233

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jan 2, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added this to the 1.6.0 milestone Jan 2, 2024
@vinnamkim vinnamkim added the DOC Improvements or additions to documentation label Jan 2, 2024
@vinnamkim vinnamkim marked this pull request as ready for review January 2, 2024 02:01
@vinnamkim vinnamkim requested review from a team as code owners January 2, 2024 02:01
@vinnamkim vinnamkim requested review from sooahleex and removed request for a team January 2, 2024 02:01
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfb6832) 80.48% compared to head (e163d59) 80.48%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1233   +/-   ##
========================================
  Coverage    80.48%   80.48%           
========================================
  Files          269      269           
  Lines        29994    29994           
  Branches      5857     5857           
========================================
+ Hits         24141    24142    +1     
  Misses        4489     4489           
+ Partials      1364     1363    -1     
Flag Coverage Δ
macos-11_Python-3.8 ?
ubuntu-20.04_Python-3.8 80.46% <ø> (ø)
windows-2022_Python-3.8 80.45% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vinnamkim vinnamkim merged commit 18a25fc into openvinotoolkit:develop Jan 2, 2024
6 of 7 checks passed
@yunchu yunchu modified the milestones: 1.6.0, 2.0.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants