Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling undefined labels at the annotation statistics #1232

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Dec 21, 2023

Summary

Regarding the issue #1204 , modify compute_ann_statistics function to handle undefined labels.
And add corresponding unit test.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi requested review from a team as code owners December 21, 2023 05:17
@jihyeonyi jihyeonyi requested review from vinnamkim and removed request for a team December 21, 2023 05:17
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cce5fc9) 80.48% compared to head (34f75ad) 80.48%.

❗ Current head 34f75ad differs from pull request most recent head 54833cc. Consider uploading reports for the commit 54833cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1232   +/-   ##
========================================
  Coverage    80.48%   80.48%           
========================================
  Files          269      269           
  Lines        29985    29993    +8     
  Branches      5856     5857    +1     
========================================
+ Hits         24133    24140    +7     
  Misses        4489     4489           
- Partials      1363     1364    +1     
Flag Coverage Δ
macos-11_Python-3.8 79.13% <100.00%> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 80.46% <100.00%> (+<0.01%) ⬆️
windows-2022_Python-3.8 80.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jihyeonyi jihyeonyi merged commit cfb6832 into openvinotoolkit:develop Dec 21, 2023
4 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/undefined_label branch December 21, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants