Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance visualizer to toggle plot title visibility #1228

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Dec 14, 2023

Summary

How to test

The existing unit test can cover show_plot_title=True option. show_plot_title=False is not covered, but manually tested. Please see this
image
It might be addressed in the future when we transition the Visualizer unit tests from the unittest to the pytest framework.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim changed the title Add option to toggle the plot title visibility Enhance visualizer to toggle plot title visibility Dec 14, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review December 14, 2023 06:45
@vinnamkim vinnamkim requested review from a team as code owners December 14, 2023 06:45
@vinnamkim vinnamkim requested review from sooahleex and removed request for a team December 14, 2023 06:45
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Dec 14, 2023
@vinnamkim vinnamkim added this to the 1.6.0 milestone Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (77199e7) 80.44% compared to head (6ea2dcf) 80.44%.

Files Patch % Lines
src/datumaro/components/visualizer.py 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1228      +/-   ##
===========================================
- Coverage    80.44%   80.44%   -0.01%     
===========================================
  Files          269      269              
  Lines        29915    29919       +4     
  Branches      5850     5851       +1     
===========================================
+ Hits         24066    24069       +3     
  Misses        4487     4487              
- Partials      1362     1363       +1     
Flag Coverage Δ
macos-11_Python-3.8 79.10% <92.30%> (-0.01%) ⬇️
ubuntu-20.04_Python-3.8 80.44% <92.30%> (-0.01%) ⬇️
windows-2022_Python-3.8 80.41% <92.30%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vinnamkim vinnamkim merged commit 044b705 into openvinotoolkit:develop Dec 14, 2023
7 checks passed
@vinnamkim vinnamkim deleted the add-option-to-toggle-plot-title-visibility branch December 14, 2023 07:10
@yunchu yunchu modified the milestones: 1.6.0, 2.0.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants