Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MMDetection COCO format importer #1213

Merged
merged 7 commits into from
Dec 1, 2023

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Dec 1, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners December 1, 2023 02:53
@wonjuleee wonjuleee requested review from jihyeonyi and removed request for a team December 1, 2023 02:53
Copy link

codecov bot commented Dec 1, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4b9f55f) 80.08% compared to head (d1f57b8) 80.10%.

Files Patch % Lines
src/datumaro/plugins/data_formats/coco/base.py 76.92% 1 Missing and 2 partials ⚠️
src/datumaro/plugins/data_formats/mmdet.py 92.10% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1213      +/-   ##
===========================================
+ Coverage    80.08%   80.10%   +0.02%     
===========================================
  Files          268      269       +1     
  Lines        29863    29915      +52     
  Branches      5845     5850       +5     
===========================================
+ Hits         23916    23964      +48     
- Misses        4614     4616       +2     
- Partials      1333     1335       +2     
Flag Coverage Δ
macos-11_Python-3.8 79.22% <88.46%> (+0.01%) ⬆️
ubuntu-20.04_Python-3.8 80.09% <88.46%> (+0.01%) ⬆️
windows-2022_Python-3.8 80.07% <88.46%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I have a feeling that we need to find a way to scale these COCO variants (like Roboflow) at the code level more efficiently. I guess that they have same file contents but different paths.

@wonjuleee
Copy link
Contributor Author

wonjuleee commented Dec 1, 2023

LGTM. However, I have a feeling that we need to find a way to scale these COCO variants (like Roboflow) at the code level more efficiently. I guess that they have same file contents but different paths.

Thank you for the comment. I agree with you. We might be able to support similar directory structures through small modifications and relaxation. This is same for other famous public formats such as VOC and Cityscapes within mmdetection document https://mmdetection.readthedocs.io/en/latest/user_guides/dataset_prepare.html. Let me think about this more for support kaggle-like datasets in the same codebase.

@wonjuleee wonjuleee merged commit bb314a1 into openvinotoolkit:develop Dec 1, 2023
6 checks passed
@yunchu yunchu added this to the 2.0.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants