Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update document regarding installation command from github #1202

Merged

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Nov 27, 2023

Summary

installation command is updated.
before: pip install 'git+https://github.com/openvinotoolkit/datumaro[default]'
after: pip install 'datumaro[default] @ git+https://github.com/openvinotoolkit/datumaro'

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi requested review from a team as code owners November 27, 2023 03:53
@jihyeonyi jihyeonyi requested review from vinnamkim and removed request for a team November 27, 2023 03:53
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7f6fea) 80.08% compared to head (753faaf) 80.07%.

❗ Current head 753faaf differs from pull request most recent head 951f648. Consider uploading reports for the commit 951f648 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1202      +/-   ##
===========================================
- Coverage    80.08%   80.07%   -0.01%     
===========================================
  Files          268      268              
  Lines        29865    29865              
  Branches      5846     5846              
===========================================
- Hits         23916    23915       -1     
  Misses        4617     4617              
- Partials      1332     1333       +1     
Flag Coverage Δ
macos-11_Python-3.8 79.19% <ø> (-0.01%) ⬇️
ubuntu-20.04_Python-3.8 80.06% <ø> (ø)
windows-2022_Python-3.8 80.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jihyeonyi jihyeonyi merged commit 44c1391 into openvinotoolkit:develop Nov 27, 2023
1 of 4 checks passed
@jihyeonyi jihyeonyi deleted the jihyeony/update-doc-installation branch November 27, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants