Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OpenVINO #1196

Merged
merged 12 commits into from
Dec 8, 2023
Merged

Upgrade OpenVINO #1196

merged 12 commits into from
Dec 8, 2023

Conversation

sovrasov
Copy link
Contributor

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@sovrasov sovrasov requested review from a team as code owners November 20, 2023 13:17
@sovrasov sovrasov requested review from vinnamkim and removed request for a team November 20, 2023 13:17
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bb314a1) 80.10% compared to head (d55fdf0) 80.10%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1196      +/-   ##
===========================================
- Coverage    80.10%   80.10%   -0.01%     
===========================================
  Files          269      269              
  Lines        29915    29915              
  Branches      5850     5850              
===========================================
- Hits         23964    23963       -1     
  Misses        4616     4616              
- Partials      1335     1336       +1     
Flag Coverage Δ
macos-11_Python-3.8 78.75% <ø> (-0.47%) ⬇️
ubuntu-20.04_Python-3.8 80.09% <ø> (-0.01%) ⬇️
windows-2022_Python-3.8 80.07% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sovrasov
Copy link
Contributor Author

@yunchu @wonjuleee in this PR, I relaxed OV requirement from == to >= to avoid cases when datumaro prevents other packages like OTX from upgrading the OV version. Do you foresee any issues if we use that strategy?
As an alternative, we can limit the upper version of OV to +2 versions from now, to enable reasonable space for the future upgrades, and avoid a complete versions mismatch in the future.

@wonjuleee
Copy link
Contributor

wonjuleee commented Nov 28, 2023

@yunchu @wonjuleee in this PR, I relaxed OV requirement from == to >= to avoid cases when datumaro prevents other packages like OTX from upgrading the OV version. Do you foresee any issues if we use that strategy? As an alternative, we can limit the upper version of OV to +2 versions from now, to enable reasonable space for the future upgrades, and avoid a complete versions mismatch in the future.

Yes, it looks much better than fixing the version. Could you update requirements-default.txt too?

@sovrasov
Copy link
Contributor Author

@yunchu @wonjuleee in this PR, I relaxed OV requirement from == to >= to avoid cases when datumaro prevents other packages like OTX from upgrading the OV version. Do you foresee any issues if we use that strategy? As an alternative, we can limit the upper version of OV to +2 versions from now, to enable reasonable space for the future upgrades, and avoid a complete versions mismatch in the future.

Yes, it looks much better than fixing the version. Could you update requirements-default.txt too?

Done

@sovrasov
Copy link
Contributor Author

@wonjuleee @yunchu apparently, unit tests on macos were killed by timeout, because they stall at some kind of download step
Is it a known issue? Unit testing on ubuntu (which probably download the same assets) was finished completed without errors
image

@wonjuleee
Copy link
Contributor

@wonjuleee @yunchu apparently, unit tests on macos were killed by timeout, because they stall at some kind of download step Is it a known issue? Unit testing on ubuntu (which probably download the same assets) was finished completed without errors image

Hi @sovrasov, this is not expected and probably make us reluctant to install this version in Datumaro.. Have you analyzed this more? This is come from the OpenVINO problem?

@sovrasov
Copy link
Contributor Author

sovrasov commented Dec 1, 2023

@wonjuleee @yunchu apparently, unit tests on macos were killed by timeout, because they stall at some kind of download step Is it a known issue? Unit testing on ubuntu (which probably download the same assets) was finished completed without errors image

Hi @sovrasov, this is not expected and probably make us reluctant to install this version in Datumaro.. Have you analyzed this more? This is come from the OpenVINO problem?

Unfortunately, this happens only on Mac platform, and can't be reproduced on Ubuntu. Do we have a Mac device to login and check?

add verbose option to see debug logging to tox
@yunchu
Copy link
Contributor

yunchu commented Dec 6, 2023

@sovrasov now i'm looking into the failure of pr-test on the macos. it seemed to be stucked at the end of processing that download a model from the ov storage but not sure why it happened only on the macos as well as not happened on the develop with previous version of openvino (2023.1).
finally, I bag your understanding that we don't have the macos machine that can be used for direct debugging.

@yunchu
Copy link
Contributor

yunchu commented Dec 6, 2023

@wonjuleee how about excluding the unittest "test_prune.py" from the macos target on this PR for further testing of the ov 2023.2 then i think we can address that issue separately after filing a bug.

@yunchu
Copy link
Contributor

yunchu commented Dec 6, 2023

@sovrasov there was misunderstanding about the stuck point in the past due to the log message flushing delays on the gh-actions job log display pane. I've checked that the testing was stucked in the call of "openvino.runtime.Core.read_model()" here by adding some dummy logging within the model downloading & infer flow.
this issue is only observed with the ov2023.2 on the macos-11.

@sovrasov
Copy link
Contributor Author

sovrasov commented Dec 6, 2023

@sovrasov there was misunderstanding about the stuck point in the past due to the log message flushing delays on the gh-actions job log display pane. I've checked that the testing was stucked in the call of "openvino.runtime.Core.read_model()" here by adding some dummy logging within the model downloading & infer flow. this issue is only observed with the ov2023.2 on the macos-11.

Thanks a lot for investigation! @wonjuleee since we don't have a mac device, can we just skip the problematic models? Apparently, the new OV has some bugs on Mac platform, but it'd be hard to make a reproducer for OV team given that we have only a gh actions executor.

@yunchu
Copy link
Contributor

yunchu commented Dec 7, 2023

FYI, @sovrasov @wonjuleee i've filed a issue #1219 for the hanging issue on the MacOS-11 with OpenVINO 2023.2 and updated TCs to be excluded from the run on macos target as workaround.

@sovrasov
Copy link
Contributor Author

sovrasov commented Dec 7, 2023

@yunchu maybe we can move the builds to the next version of MacOS?
11.x was discontinued recently: https://endoflife.date/macos

@sovrasov
Copy link
Contributor Author

sovrasov commented Dec 7, 2023

@vinnamkim please have a look as well

@wonjuleee wonjuleee merged commit 3782380 into openvinotoolkit:develop Dec 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants