-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade OpenVINO #1196
Upgrade OpenVINO #1196
Conversation
7608a09
to
acc79a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1196 +/- ##
===========================================
- Coverage 80.10% 80.10% -0.01%
===========================================
Files 269 269
Lines 29915 29915
Branches 5850 5850
===========================================
- Hits 23964 23963 -1
Misses 4616 4616
- Partials 1335 1336 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@yunchu @wonjuleee in this PR, I relaxed OV requirement from == to >= to avoid cases when datumaro prevents other packages like OTX from upgrading the OV version. Do you foresee any issues if we use that strategy? |
Yes, it looks much better than fixing the version. Could you update |
Done |
@wonjuleee @yunchu apparently, unit tests on macos were killed by timeout, because they stall at some kind of download step |
Hi @sovrasov, this is not expected and probably make us reluctant to install this version in Datumaro.. Have you analyzed this more? This is come from the OpenVINO problem? |
Unfortunately, this happens only on Mac platform, and can't be reproduced on Ubuntu. Do we have a Mac device to login and check? |
add verbose option to see debug logging to tox
@sovrasov now i'm looking into the failure of pr-test on the macos. it seemed to be stucked at the end of processing that download a model from the ov storage but not sure why it happened only on the macos as well as not happened on the develop with previous version of openvino (2023.1). |
@wonjuleee how about excluding the unittest "test_prune.py" from the macos target on this PR for further testing of the ov 2023.2 then i think we can address that issue separately after filing a bug. |
@sovrasov there was misunderstanding about the stuck point in the past due to the log message flushing delays on the gh-actions job log display pane. I've checked that the testing was stucked in the call of "openvino.runtime.Core.read_model()" here by adding some dummy logging within the model downloading & infer flow. |
Thanks a lot for investigation! @wonjuleee since we don't have a mac device, can we just skip the problematic models? Apparently, the new OV has some bugs on Mac platform, but it'd be hard to make a reproducer for OV team given that we have only a gh actions executor. |
FYI, @sovrasov @wonjuleee i've filed a issue #1219 for the hanging issue on the MacOS-11 with OpenVINO 2023.2 and updated TCs to be excluded from the run on macos target as workaround. |
@yunchu maybe we can move the builds to the next version of MacOS? |
@vinnamkim please have a look as well |
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.