Update publish workflow to use internal pypi #1191
Conversation
yunchu
force-pushed
the
infra/update-publish-workflow
branch
from
77a33bb
to
1a38db6
Compare
|
Why do we have to do this? |
yunchu
force-pushed
the
infra/update-publish-workflow
branch
from
1a38db6
to
58eb5b6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## releases/1.5.0 #1191 +/- ##
===============================================
Coverage 79.97% 79.97%
===============================================
Files 265 265
Lines 29705 29705
Branches 5831 5831
===============================================
Hits 23756 23756
Misses 4617 4617
Partials 1332 1332
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| run: | | ||
| export no_proxy=${{ secrets.PYPI_HOST }} | ||
| export REPOSITORY_URL=http://${{ secrets.PYPI_HOST }}:${{ secrets.PYPI_PORT }} | ||
| twine upload --verbose --repository-url $REPOSITORY_URL dist/* -u ${{ secrets.PYPI_USER }} -p ${{ secrets.PYPI_PASSWORD }} | ||
| # - name: Publish package distributions to TestPyPI | ||
| # if: ${{ steps.check-tag.outputs.match == '' }} | ||
| # uses: pypa/gh-action-pypi-publish@v1.7.1 | ||
| # with: | ||
| # password: ${{ secrets.TESTPYPI_API_TOKEN }} | ||
| # repository-url: https://test.pypi.org/legacy/ | ||
| # verbose: true |
There was a problem hiding this comment.
Why did you remove the existing publish pipeline (to public PYPI)?
There was a problem hiding this comment.
due to the action pypa/gh-action-pypi-publish need to have 'docker' inside of the ci-runner machine but did not have that. I will update those part to use 'twine' next time.
There was a problem hiding this comment.
and as I've told you in IM, publishing to the public PyPI will be done manually
yunchu
force-pushed
the
infra/update-publish-workflow
branch
2 times, most recently
from
a9318c5
to
6530ca6
Compare
yunchu
force-pushed
the
infra/update-publish-workflow
branch
from
6530ca6
to
54c06b4
Compare
|
I just added a new workflow which only works for manual triggering to publish whl files to the internal pypi. @wonjuleee @vinnamkim please review this PR again. |
There was a problem hiding this comment.
I still don't know why there exist two CI code pieces doing almost same. Do you have a plan to clean them in the future https://docs.github.com/en/actions/using-workflows/reusing-workflows#calling-a-reusable-workflow?
There was a problem hiding this comment.
yes, I will update publish workflows to use some reusable workflow later.
Summary
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.