Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAM OVMS and Triton server Docker image builders #1129

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Aug 24, 2023

Summary

  • Ticket no. 116107
  • Add Segment Anything Model OVMS and Triton server Docker image builders. This will be used for the future dataset transform features with the dedicated inference server launchers.

How to test

I added a Jupyter notebook example to test the SAM server instances.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim vinnamkim changed the title Add SAM Triton server Docker image building Add SAM Triton server Docker image builder Aug 24, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added this to the 1.5.0 milestone Aug 24, 2023
@vinnamkim vinnamkim marked this pull request as ready for review August 24, 2023 14:31
@vinnamkim vinnamkim requested review from a team as code owners August 24, 2023 14:31
@vinnamkim vinnamkim requested review from sooahleex and removed request for a team August 24, 2023 14:31
@vinnamkim vinnamkim added the FEATURE New feature & functionality label Aug 24, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf244a2) 80.00% compared to head (8374659) 80.00%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1129   +/-   ##
========================================
  Coverage    80.00%   80.00%           
========================================
  Files          258      258           
  Lines        29233    29233           
  Branches      5728     5728           
========================================
  Hits         23389    23389           
  Misses        4505     4505           
  Partials      1339     1339           
Flag Coverage Δ
macos-11_Python-3.8 79.10% <ø> (+<0.01%) ⬆️
ubuntu-20.04_Python-3.8 79.98% <ø> (ø)
windows-2019_Python-3.8 79.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim changed the title Add SAM Triton server Docker image builder Add SAM OVMS and Triton server Docker image builders Aug 25, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vinnamkim vinnamkim merged commit 8ffe5f1 into openvinotoolkit:develop Aug 29, 2023
6 of 9 checks passed
@vinnamkim vinnamkim deleted the feature/add-sam-triton-server-docker-building branch August 29, 2023 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants