Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support video annotation #1124

Merged

Conversation

bonhunko
Copy link
Contributor

@bonhunko bonhunko commented Aug 14, 2023

Summary

CVS-116105

Support the video annotation type for 'datumaro', 'datumaro_binary' format

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@bonhunko bonhunko requested review from a team as code owners August 14, 2023 00:19
@bonhunko bonhunko requested review from jihyeonyi and removed request for a team August 14, 2023 00:19
@bonhunko bonhunko marked this pull request as draft August 14, 2023 00:21
@bonhunko bonhunko force-pushed the feature/video_annotation_support branch from 7a7fdd4 to a1bb0f4 Compare August 14, 2023 00:22
@bonhunko bonhunko marked this pull request as ready for review August 14, 2023 00:25
@bonhunko bonhunko force-pushed the feature/video_annotation_support branch from a1bb0f4 to b696679 Compare August 14, 2023 00:37
@bonhunko bonhunko marked this pull request as draft August 14, 2023 00:38
@bonhunko bonhunko changed the title support video annotation [WIP] support video annotation Aug 14, 2023
@bonhunko bonhunko marked this pull request as ready for review August 14, 2023 00:39
@bonhunko bonhunko force-pushed the feature/video_annotation_support branch 3 times, most recently from 259da72 to 281259d Compare August 14, 2023 00:45
@bonhunko bonhunko changed the title [WIP] support video annotation support video annotation Aug 14, 2023
@bonhunko bonhunko force-pushed the feature/video_annotation_support branch from 281259d to 8cbadb1 Compare August 14, 2023 00:52
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 84.53% and project coverage change: +0.02% 🎉

Comparison is base (0d5311e) 79.98% compared to head (2e6948b) 80.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1124      +/-   ##
===========================================
+ Coverage    79.98%   80.00%   +0.02%     
===========================================
  Files          258      258              
  Lines        29148    29233      +85     
  Branches      5710     5728      +18     
===========================================
+ Hits         23314    23388      +74     
- Misses        4500     4506       +6     
- Partials      1334     1339       +5     
Flag Coverage Δ
macos-11_Python-3.8 79.10% <84.53%> (+0.01%) ⬆️
ubuntu-20.04_Python-3.8 ?
windows-2019_Python-3.8 79.92% <84.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/datumaro/plugins/data_formats/arrow/exporter.py 74.88% <ø> (+1.42%) ⬆️
...umaro/plugins/data_formats/datumaro_binary/base.py 93.22% <33.33%> (-1.61%) ⬇️
src/datumaro/components/exporter.py 83.33% <70.58%> (-1.05%) ⬇️
src/datumaro/components/media.py 79.18% <83.33%> (+0.06%) ⬆️
...datumaro/plugins/data_formats/datumaro/exporter.py 94.94% <88.23%> (-0.48%) ⬇️
src/datumaro/plugins/data_formats/datumaro/base.py 88.04% <89.47%> (+0.01%) ⬆️
...ugins/data_formats/datumaro_binary/mapper/media.py 88.99% <90.00%> (+2.32%) ⬆️
src/datumaro/components/annotation.py 89.55% <100.00%> (+0.03%) ⬆️
...c/datumaro/plugins/data_formats/datumaro/format.py 100.00% <100.00%> (ø)
...o/plugins/data_formats/datumaro_binary/exporter.py 95.74% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bonhunko bonhunko marked this pull request as draft August 14, 2023 04:04
@bonhunko bonhunko force-pushed the feature/video_annotation_support branch from 8cbadb1 to e058b0a Compare August 14, 2023 06:20
@bonhunko bonhunko marked this pull request as ready for review August 14, 2023 07:14
@bonhunko bonhunko added the data formats PR is related to dataset formats label Aug 14, 2023
@bonhunko bonhunko added this to the 1.5.0 milestone Aug 14, 2023
@bonhunko bonhunko force-pushed the feature/video_annotation_support branch 7 times, most recently from c9f312b to 00c81e3 Compare August 17, 2023 04:14
@bonhunko bonhunko force-pushed the feature/video_annotation_support branch 2 times, most recently from 43beee2 to 0eee6cd Compare August 17, 2023 04:42
@bonhunko bonhunko force-pushed the feature/video_annotation_support branch from 0eee6cd to 2e6948b Compare August 17, 2023 04:43
Copy link
Contributor

@jihyeonyi jihyeonyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your effort.

@bonhunko bonhunko merged commit 4f848c9 into openvinotoolkit:develop Aug 17, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data formats PR is related to dataset formats
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants