Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace xml.etree.ElementTree with defusedxml #1117

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Aug 3, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners August 3, 2023 02:09
@wonjuleee wonjuleee requested review from jihyeonyi and removed request for a team August 3, 2023 02:09
@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (04dff62) 79.98% compared to head (9b19109) 79.98%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1117   +/-   ##
========================================
  Coverage    79.98%   79.98%           
========================================
  Files          258      258           
  Lines        29300    29300           
  Branches      5740     5740           
========================================
+ Hits         23435    23437    +2     
  Misses        4515     4515           
+ Partials      1350     1348    -2     
Flag Coverage Δ
macos-11_Python-3.8 79.08% <100.00%> (ø)
ubuntu-20.04_Python-3.8 79.97% <100.00%> (ø)
windows-2019_Python-3.8 79.90% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/datumaro/plugins/data_formats/roboflow/base.py 86.30% <100.00%> (ø)
...datumaro/plugins/data_formats/roboflow/importer.py 83.96% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit 993c9f0 into openvinotoolkit:develop Aug 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants