Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update contributing.md #1094

Merged
merged 4 commits into from
Jul 13, 2023
Merged

update contributing.md #1094

merged 4 commits into from
Jul 13, 2023

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Jul 13, 2023 •
edited
Loading

Summary

describe development process more specifically.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

yunchu and others added 2 commits July 7, 2023 21:02
@jihyeonyi jihyeonyi marked this pull request as ready for review July 13, 2023 05:16
@jihyeonyi jihyeonyi requested review from a team as code owners July 13, 2023 05:16
@jihyeonyi jihyeonyi requested review from sooahleex and removed request for a team July 13, 2023 05:16
@jihyeonyi
Copy link
Contributor Author

I'm not sure this update is also added to CHANGELOG. If needed, please let me know.

sooahleex
sooahleex approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. By the way, I think this could be merged into releases/1.4.0.

@vinnamkim vinnamkim changed the base branch from develop to releases/1.4.0 July 13, 2023 06:41
@vinnamkim vinnamkim added the DOC Improvements or additions to documentation label Jul 13, 2023
@vinnamkim vinnamkim added this to the 1.4.0 milestone Jul 13, 2023
@jihyeonyi jihyeonyi merged commit a2b6d08 into openvinotoolkit:releases/1.4.0 Jul 13, 2023
4 checks passed
@jihyeonyi jihyeonyi deleted the update_contributing branch July 13, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnamkim vinnamkim vinnamkim approved these changes

@sooahleex sooahleex sooahleex approved these changes

Assignees
No one assigned
Labels
DOC Improvements or additions to documentation
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jihyeonyi @vinnamkim @sooahleex @yunchu