Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tabular dataset support #1089

Merged
merged 8 commits into from
Jul 14, 2023
Merged

tabular dataset support #1089

merged 8 commits into from
Jul 14, 2023

Conversation

jihyeonyi
Copy link
Contributor

@jihyeonyi jihyeonyi commented Jul 11, 2023 •
edited
Loading

Summary

This PR includes,

  • media type for tabular data
  • tabular dataset importer
  • tabular dataset exporter

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@jihyeonyi jihyeonyi marked this pull request as ready for review July 13, 2023 02:50
@jihyeonyi jihyeonyi requested review from a team as code owners July 13, 2023 02:50
@jihyeonyi jihyeonyi requested review from bonhunko and removed request for a team July 13, 2023 02:50
bonhunko
bonhunko suggested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logics and implementation are good to me.
I add some comments regards to the code syntax.

src/datumaro/components/media.py Outdated Show resolved Hide resolved
src/datumaro/plugins/data_formats/tabular.py Outdated Show resolved Hide resolved
src/datumaro/plugins/data_formats/tabular.py Outdated Show resolved Hide resolved
src/datumaro/plugins/data_formats/tabular.py Outdated Show resolved Hide resolved
src/datumaro/plugins/data_formats/tabular.py Outdated Show resolved Hide resolved
src/datumaro/components/media.py Outdated Show resolved Hide resolved
src/datumaro/components/media.py Outdated Show resolved Hide resolved
src/datumaro/components/media.py Outdated Show resolved Hide resolved
src/datumaro/plugins/data_formats/tabular.py Outdated Show resolved Hide resolved
tests/integration/cli/test_tabular_format.py Outdated Show resolved Hide resolved
@yunchu
Copy link
Contributor

yunchu commented Jul 13, 2023

@jihyeonyi please set the proper milestone for this PR. thanks.

jihyeonyi and others added 2 commits July 13, 2023 17:05
@jihyeonyi jihyeonyi added this to the 1.5.0 milestone Jul 13, 2023
bonhunko
bonhunko approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@bonhunko bonhunko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your quick update. LGTM!

@jihyeonyi jihyeonyi merged commit d425d26 into openvinotoolkit:develop Jul 14, 2023
4 checks passed
@jihyeonyi jihyeonyi deleted the tabular branch July 14, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnamkim vinnamkim vinnamkim left review comments

@bonhunko bonhunko bonhunko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jihyeonyi @yunchu @vinnamkim @bonhunko