Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Create Datumaro cache dir #1088

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jul 10, 2023

Summary

  • This is because Geti containers have no write access.
  • Do not create Datumaro cache dir when just importing datumaro
  • Raise an error log and do not terminate it if it is not possible to create the cache directory.

How to test

I added a test for this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review July 10, 2023 22:39
@vinnamkim vinnamkim requested review from a team as code owners July 10, 2023 22:39
@vinnamkim vinnamkim requested review from jihyeonyi and removed request for a team July 10, 2023 22:39
@vinnamkim vinnamkim added this to the 1.4.0 milestone Jul 10, 2023
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Jul 10, 2023
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
jihyeonyi
jihyeonyi previously approved these changes Jul 10, 2023
@jihyeonyi jihyeonyi self-requested a review July 10, 2023 23:49
@jihyeonyi jihyeonyi dismissed their stale review July 10, 2023 23:51

I'll approve this after all tests are passed.

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim merged commit c48c128 into openvinotoolkit:releases/1.4.0 Jul 11, 2023
4 checks passed
@vinnamkim vinnamkim deleted the hotfix/create-cache-dir branch July 11, 2023 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants