Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UnionMerge #1086

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Fix UnionMerge #1086

merged 4 commits into from
Jul 12, 2023

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Jul 10, 2023 •
edited
Loading

Summary

When importing cable category in MVTec anomaly data, the current implementation shows KeyError.
Because self._matching_table only stores the label mapping with different indices and some labels should keep the original indices, the codes raises the KeyError for keeping labels.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@wonjuleee wonjuleee requested review from a team as code owners July 10, 2023 05:22
@wonjuleee wonjuleee requested review from vinnamkim and removed request for a team July 10, 2023 05:22
@wonjuleee wonjuleee changed the base branch from develop to releases/1.4.0 July 10, 2023 05:23
@wonjuleee wonjuleee added the BUG Something isn't working label Jul 10, 2023
vinnamkim
vinnamkim reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you describe why this fix is needed and add a test case to reproduce the bug?

@wonjuleee
Copy link
Contributor Author

Would you describe why this fix is needed and add a test case to reproduce the bug?

I have added the test taking care of mixed categories between datasets (same to MVTec dataset).

@vinnamkim vinnamkim added this to the 1.4.0 milestone Jul 12, 2023
vinnamkim
vinnamkim approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit 5e54872 into openvinotoolkit:releases/1.4.0 Jul 12, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinnamkim vinnamkim vinnamkim approved these changes

Assignees
No one assigned
Labels
BUG Something isn't working
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wonjuleee @vinnamkim