Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mask annotations for CVAT data format #1078

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Support mask annotations for CVAT data format #1078

merged 5 commits into from
Jul 6, 2023

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Jul 5, 2023 •
edited
Loading

Summary

How to test

I update save and load test for this change and mannually check it for the CVAT exported dataset with mask annotations: car_tree_bug_seg_cvat_project.zip.
image

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@vinnamkim
Support mask annotations in CVAT data format
34fa912 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim marked this pull request as ready for review July 5, 2023 09:26
@vinnamkim vinnamkim requested review from a team as code owners July 5, 2023 09:26
@vinnamkim vinnamkim added the ENHANCE Enhancement of existing features label Jul 5, 2023
@vinnamkim vinnamkim added this to the 1.4.0 milestone Jul 5, 2023
@vinnamkim
Update CHANGELOG.md
164b791 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim
Update docs
b20364d 
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@vinnamkim vinnamkim added the FEATURE New feature & functionality label Jul 6, 2023
sooahleex
sooahleex approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@sooahleex sooahleex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vinnamkim vinnamkim merged commit 08052c6 into openvinotoolkit:develop Jul 6, 2023
@vinnamkim vinnamkim deleted the enhance/support-cvat-mask-annotation branch July 6, 2023 04:37
@vinnamkim vinnamkim mentioned this pull request Jul 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sooahleex sooahleex sooahleex approved these changes

@yunchu yunchu Awaiting requested review from yunchu yunchu is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@jihyeonyi jihyeonyi Awaiting requested review from jihyeonyi jihyeonyi is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@MarkByun MarkByun Awaiting requested review from MarkByun MarkByun is a code owner automatically assigned from openvinotoolkit/datumaro-admins

@bonhunko bonhunko Awaiting requested review from bonhunko bonhunko is a code owner automatically assigned from openvinotoolkit/datumaro-admins

Assignees
No one assigned
Labels
ENHANCE Enhancement of existing features FEATURE New feature & functionality
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

cannot import mask from cvat dataset.
2 participants
@vinnamkim @sooahleex